#629 Add kwarg 'reset_socket' to disable closing sockets on error #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
janiversen
approved these changes
May 13, 2021
camtarn
pushed a commit
to camtarn/pymodbus
that referenced
this pull request
Dec 6, 2021
pymodbus-dev#629 Add kwarg 'reset_socket' to disable closing sockets on error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #629
Starting pymodbus 2.5.0 on error client is closed and a new socket is initialized on a new request. This seems to be having adverse effect on the functionality of pymodbus with some of the hardwares. As a workaround, introducing new kwarg
reset_socketwhich is set toTrueby default implying socket will be closed on error. Setting this toFalsewill keep the socket open till client is explicitly closed or application is stopped.Example usage