Allow specification of client connection handler in Modbus...Server #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o ModbusTcpServer and ModbusUdpServer allows handler class other than
default Modbus{Connected,Disconnected}RequestHandler
o Add debug logging on request failure, to help diagnose root causes
bashwork
added a commit
that referenced
this pull request
Jul 18, 2014
Allow specification of client connection handler in Modbus...Server
ocschwar
pushed a commit
to ocschwar/pymodbus
that referenced
this pull request
Jun 22, 2016
dhoomakethu
pushed a commit
that referenced
this pull request
May 16, 2017
Allow specification of client connection handler in Modbus...Server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to supply an alternative request handler class to ModbusTcpServer. This prevents writing a server that responds cleanly to shutdown, since each client service Thread blocks indefinitely awaiting input from that client. Provide a means to supply an alternative request handler class to ModbusTcpServer (and ModbusUdpServer).
o ModbusTcpServer and ModbusUdpServer allows handler class other than
default Modbus{Connected,Disconnected}RequestHandler
o Add debug logging on request failure, to help diagnose root causes