Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename ModbusExceptions enums to legal constants. #2436

Merged
merged 9 commits into from
Nov 4, 2024
Merged

rename ModbusExceptions enums to legal constants. #2436

merged 9 commits into from
Nov 4, 2024

Conversation

janiversen
Copy link
Collaborator

@janiversen janiversen commented Nov 4, 2024 •
edited
Loading

datastore needs to be refactored with a number of features:

  • only store registers
  • setValues -> setRegister, setBool
  • handle diag/Mei/file function codes

But that is for another day.

@janiversen janiversen changed the title Clean typing for registers/bits in pdu and datastore. rename ModbusExceptions enums to legal constants. Nov 4, 2024
@janiversen janiversen merged commit 7bd9cb4 into dev Nov 4, 2024
1 check passed
@janiversen janiversen deleted the pdu4 branch November 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janiversen