Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type of parameter values of write_registers #2411

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Improve type of parameter values of write_registers #2411

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2554b0
to allow to use write_registers typecorrectly with values as inhomoge…
MAKOMO Oct 24, 2024
7b2f3de
use 'collections.abc.Sequence' instead of the deprecated 'typing.Sequ…
MAKOMO Oct 24, 2024
e31d81e
fix import order as suggested by ruff
MAKOMO Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pymodbus/client/mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from __future__ import annotations

import struct
from collections.abc import Sequence
from enum import Enum
from typing import Generic, TypeVar

Expand Down Expand Up @@ -341,7 +342,7 @@ def write_coils(
def write_registers(
self,
address: int,
values: list[bytes | int],
values: Sequence[bytes | int],
slave: int = 1,
skip_encode: bool = False,
no_response_expected: bool = False
Expand Down