-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.rst #2351
Update README.rst #2351
Conversation
URL for Server Documentation Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Hi, @janiversen Instead of - [ https://github.com/pymodbus-dev/pymodbus/blob/dcbcfd7f16fb3be82525bccf9699855a06f900c5/README.rst ] |
Pull requests are welcome |
Unable to find [ Edit on GitHub ] in readme.html may be it is in - https://pymodbus.readthedocs.io |
Basically I am not sure what your problem is, I just tested edit and it worked without problems. seems you are trying to edit readme.html and not README.rst which is another file. readme.html is solely a link file why would you want to edit that ? |
Basically, i want to change URL for Edit on Github to this new URL - https://github.com/pymodbus-dev/pymodbus/blob/dcbcfd7f16fb3be82525bccf9699855a06f900c5/README.rst please find reference video PyModbus.-.A.Python.Modbus.Stack.PyModbus.3.7.2.documentation.-.Google.Chrome.2024-10-08.12-58-55.mp4 |
Just checked https://pymodbus.readthedocs.io/en/latest/source/readme.html No "edit on github", but clicking "view page sourc" works nicely. It seems you have other options set. Please jump to github if you want to edit files. |
The "edit on github" is not something we configure ! and not something we recommend. the link file points correctly:
|
If you look at conf.py, you will see that "edit on github" is not activated", meaning sphinx do not generate the breadcrumb, so that would be the first thing to change. Secondly you probably need to rename readme.rst to README.rst good luck, looking forward to see a pull request. |
yes thank you |
hope this works - #2357 |
URL for Server Documentation Updated.
Previous URL - https://pymodbus.readthedocs.io/en/latest/source/library/server.html
Proposed URL - https://pymodbus.readthedocs.io/en/latest/source/server.html