Update solar.py #2316
Merged
Update solar.py #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the name "solar" and the registers and their length listed, this contrib example was meant for Huawei SUN2000 inverters. I have such an inverter ans the script did not work. After this adaptation the script works as good as it can and the registers are documented and an log.info shows the value read, if there was no error.
|
LGTM, thanks. pymodbus already contains methods to convert registers <-> int32/int64/float32/float64... but anyhow I cannot find your proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the name "solar", the registers and their length listed, this contrib example was meant for Huawei SUN2000 inverters.
I have such an inverter and the script did not work. After this adaptation the script works as good as it can, the registers are (kind of) documented and a log.info shows the value read, if there was no error.
An implementation of ModbusClient.convert_from_registers is proposed
The script returns someting like