Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildPacket can be used for Request and Response #2262

Merged
merged 2 commits into from
Jul 24, 2024
Merged

buildPacket can be used for Request and Response #2262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e74935
buildPacket can be used for Request and Response
Jul 24, 2024
36f0379
Merge branch 'dev' into buildPacket-type
janiversen Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymodbus/framer/old_framer_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from pymodbus.factory import ClientDecoder, ServerDecoder
from pymodbus.framer.base import FramerBase
from pymodbus.logging import Log
from pymodbus.pdu import ModbusRequest
from pymodbus.pdu import ModbusRequest, ModbusResponse


if TYPE_CHECKING:
Expand Down Expand Up @@ -158,7 +158,7 @@ def frameProcessIncomingPacket(
) -> None:
"""Process new packet pattern."""

def buildPacket(self, message: ModbusRequest) -> bytes:
def buildPacket(self, message: ModbusRequest | ModbusResponse) -> bytes:
"""Create a ready to send modbus packet.

:param message: The populated request/response to send
Expand Down