Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_simulator: use unused_tcp_port fixture #2141

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ilkka-ollakka
Copy link
Contributor

default port 8080 can be in use when running test in developer machine, so better to use port that is available

default port 8080 can be in use when running test in developer maching, so better to use port that is available
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, please solve your CI error.

@janiversen janiversen merged commit a2e82d5 into pymodbus-dev:dev Apr 2, 2024
1 check passed
@janiversen
Copy link
Collaborator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants