Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Message_Parser example #2079

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

CapraTheBest
Copy link
Contributor

After updating the library to the latest version I started having issues with the Message_Parser example (#2078). After looking into it I've found that it was still using old calls. I've removed them and also made the "-log" function work again properly.
If there are any issues please let me know.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

You have a Ruff issue.

Running ./check_ci.sh locally is your friend.

@CapraTheBest
Copy link
Contributor Author

Should be good now.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 43ec707 into pymodbus-dev:dev Mar 5, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants