Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "new" inter_byte_timeout and is_open for pyserial #2031

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Use "new" inter_byte_timeout and is_open for pyserial #2031

merged 2 commits into from
Feb 20, 2024

Conversation

alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Feb 20, 2024 •
edited
Loading

pyserial defines a class Socket which used to have a property interCharTimeout.

This was renamed to inter_byte_timeout in pyserial>=3.0. interCharTimeout remains as an alias for now.

I do not believe this is an API change since it's only internal, and users set strict: True on ModbusSerialClient instead.

is_open has also been available since 3.0 so there is no need to keep the deprecated isOpen()

@alexrudd2 alexrudd2 requested a review from janiversen February 20, 2024 00:28
@alexrudd2 alexrudd2 changed the title Use new inter_byte_timeout Use "new" inter_byte_timeout and is_open for pyserial Feb 20, 2024
@janiversen janiversen merged commit fe809d9 into dev Feb 20, 2024
1 check passed
@janiversen janiversen deleted the inter-byte-timeout branch February 20, 2024 07:26
@alexrudd2 alexrudd2 mentioned this pull request Feb 20, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen Awaiting requested review from janiversen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen