Make ModbusClientMixin Generic to fix type issues for sync and async

[laundmo]

this way, the concrete client can specify the generic response return type.

closes: #1973

[janiversen]

A very elegant PR, I like it !!

I see that CI is failing with mypy complaining, please fix that, along with the couple of review comments I made.

[janiversen]

@alexrudd2 Can you please have a look at this PR, from the typing perspective ? I see it as a very elegant solution to the problem at hand, but you know I am by far not the expert on mypy.

[janiversen]

Once you feel its ready to go, please re-request review.

[alexrudd2]

@alexrudd2 Can you please have a look at this PR, from the typing perspective ? I see it as a very elegant solution to the problem at hand, but you know I am by far not the expert on mypy.

Sure, it may take me a few days though

[alexrudd2]

You clearly know more than me about Python types, and this is a good solution to a problem Jan and I wasted a lot of cycles on. Thank you.

[alexrudd2]

Oh, if I had to guess you didn't find check_ci.sh or the git hook. (That should be described in CONTRIBUTING.md) Also, you may want to consider installing the ruff extension into VSCode.

[janiversen]

It is in README:

Development Instructions
------------------------
The current code base is compatible with python >= 3.8.

Here are some of the common commands to perform a range of activities::

   source .venv/bin/activate   <-- Activate the virtual environment
   ./check_ci.sh               <-- run the same checks as CI runs on a pull request.

[janiversen]

Let get this merged...

@laundmo I look forward to see followup PR, you really did magic here !

[janiversen]

LGTM, thanks a lot.

The open comments are not urgent.

[janiversen]

need to please ruff