More elegant noop #1859
Merged
More elegant noop #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexrudd2 you were the one who suggested to use "lambda: None" :-) so lets see if mypy in CI accepts it. |
|
mypy in CI accepts the |
|
Well we are a long way from putting mypy in strict mode, not sure that will ever happen. |
|
Aha, but we are close to |
alexrudd2
added a commit
that referenced
this pull request
Oct 31, 2023
This reverts commit 5d1b59f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the _noop introduced, with a more elegant one line solution.