Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid malicious user path input #1855

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Avoid malicious user path input #1855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47e9857
Avoid malicious user path input
alexrudd2 Oct 25, 2023
1de81d2
Update http_server.py
janiversen Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pymodbus/server/simulator/http_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,9 @@ async def handle_html_static(self, request):
"""Handle static html."""
if not (page := request.path[1:]):
page = "index.html"
file = os.path.join(self.web_path, page)
file = os.path.normpath(os.path.join(self.web_path, page))
if not file.startswith(self.web_path):
raise ValueError(f"File access outside {self.web_path} not permitted.")
try:
with open(file, encoding="utf-8"):
return web.FileResponse(file)
Expand Down