Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import aiohttp in way pleasing mypy. #1818

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Import aiohttp in way pleasing mypy. #1818

merged 1 commit into from
Oct 14, 2023

Conversation

janiversen
Copy link
Collaborator

No description provided.

@janiversen janiversen merged commit 3a919d7 into dev Oct 14, 2023
1 check passed
@janiversen janiversen deleted the opt_import branch October 14, 2023 19:07
@alexrudd2
Copy link
Collaborator

This actually does not do what you intended, if aiohttp is not installed. I will submit a PR

>       if not web:
E       NameError: name 'web' is not defined

@alexrudd2 alexrudd2 mentioned this pull request Oct 17, 2023
Closed
@janiversen
Copy link
Collaborator Author

It actually does, we do the same with pyserial.

If you call the methods using it without having it installed it's ok to get an error.

However if you have a better solution, then please.....but also in transport_serial.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janiversen @alexrudd2