Handle partial message in ReadDeviceInformationResponse #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
requested changes
Aug 16, 2023
When a partial message is received for a ReadDeviceInformationResponse,
an exception occurs when calculating the frame size:
ERROR:asyncio:Exception in callback SerialTransport._read_ready()
handle: <Handle SerialTransport._read_ready()>
Traceback (most recent call last):
File "/usr/lib/python3.9/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)
File "pymodbus/transport/transport_serial.py", line 109, in _read_ready
self._protocol.data_received(data)
File "pymodbus/transport/transport.py", line 307, in data_received
self.datagram_received(data, None)
File "pymodbus/transport/transport.py", line 328, in datagram_received
cut = self.callback_data(self.recv_buffer, addr=addr)
File "pymodbus/client/base.py", line 218, in callback_data
self.framer.processIncomingPacket(data, self._handle_response, slave=0)
File "pymodbus/framer/base.py", line 137, in processIncomingPacket
self.frameProcessIncomingPacket(single, callback, slave, **kwargs)
File "pymodbus/framer/rtu_framer.py", line 213, in frameProcessIncomingPacket
if not self.isFrameReady():
File "pymodbus/framer/rtu_framer.py", line 134, in isFrameReady
size = self.populateHeader()
File "pymodbus/framer/rtu_framer.py", line 152, in populateHeader
size = self.get_expected_response_length(data)
File "pymodbus/framer/rtu_framer.py", line 320, in get_expected_response_length
return pdu_class.calculateRtuFrameSize(data)
File "mei_message.py", line 130, in calculateRtuFrameSize
_, object_length = struct.unpack(">BB", buffer[size : size + 2])
struct.error: unpack requires a buffer of 2 bytes
The caller is expecting an IndexError if there isn't enough data in the
packet. So to fix this, catch the struct error and raise an IndexError.
|
Sorry, I was rushing to get that done last night. I had fixed the linter error but forgot to commit the fix. Should pass now. Thanks! |
|
Thanks, looking forward to see other pull requests from you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a partial message is received for a ReadDeviceInformationResponse, an exception occurs when calculating the frame size:
The caller is expecting an IndexError if there isn't enough data in the packet. So to fix this, catch the struct error and raise an IndexError.