Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impoved the example "server_updating.py" #1720

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Impoved the example "server_updating.py" #1720

merged 4 commits into from
Aug 13, 2023

Conversation

aloishockenschlohe
Copy link
Contributor

@aloishockenschlohe aloishockenschlohe commented Aug 3, 2023

Added some comments to explain the code a bit better.
Changed the update routine to have a more expressive example.

examples/server_updating.py Show resolved Hide resolved
examples/server_updating.py Outdated Show resolved Hide resolved
examples/server_updating.py Outdated Show resolved Hide resolved
examples/server_updating.py Outdated Show resolved Hide resolved
examples/server_updating.py Outdated Show resolved Hide resolved
@janiversen
Copy link
Collaborator

Please also solve the CI linter error.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have a spelling problem see CI error

examples/server_updating.py Outdated Show resolved Hide resolved
aloishockenschlohe and others added 4 commits August 13, 2023 11:09
Added some comments to explain the code a bit better.
Changed the update routine to have a more expressive example.
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 0852961 into pymodbus-dev:dev Aug 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants