Fix custom message parsing in RTU framer #1716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the regression reported in #1695 still isn't resolved in pyModbus 3.4.1, I've been tinkering with the code to try to reproduce the issue.
I noticed that
ModbusRtuFramer
caches the function codes registered in the decoder lookup table. As the framer is already initialized before a client can call theregister()
function to register custom Modbus message types, this prevents those custom Modbus messages from being processed correctly.This PR uses
.keys()
instead ofset()
which preventsfunction_codes
from becoming outdated if a custom message class is registered.Open question: if there a valid case for the decoder being None? Otherwise we can drop the fallback to
{}
?