Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding flake8-pytest-style to ruff #1520

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Adding flake8-pytest-style to ruff #1520

merged 3 commits into from
Apr 25, 2023

Conversation

jamesbraza
Copy link
Contributor

janiversen
janiversen reviewed Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are ok, but the configuration changes is something I would like @alexrudd2 to approve.

@alexrudd2 if you approve, please merge.

janiversen
janiversen approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved.

@alexrudd2 alexrudd2 self-requested a review April 25, 2023 14:35
alexrudd2
alexrudd2 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@alexrudd2 alexrudd2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think it's valuable to stay close to the default config.

@alexrudd2 alexrudd2 merged commit b6384d0 into pymodbus-dev:dev Apr 25, 2023
@alexrudd2 alexrudd2 mentioned this pull request Apr 25, 2023
Closed
@jamesbraza jamesbraza deleted the flake8-pytest-style branch April 25, 2023 17:03
@jamesbraza jamesbraza mentioned this pull request Apr 25, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexrudd2 alexrudd2 alexrudd2 approved these changes

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate flake8-pytest-style as a linter
3 participants
@jamesbraza @janiversen @alexrudd2