Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Server - Provide an option to start reactor outside StartTcpServer function #284

Closed
dhoomakethu opened this issue Mar 29, 2018 · 1 comment
Closed

Async Server - Provide an option to start reactor outside StartTcpServer function #284

dhoomakethu opened this issue Mar 29, 2018 · 1 comment
Labels
Enhancements

Comments

@dhoomakethu
Copy link
Contributor

Versions

  • Python: 2.7 - 3.x
  • OS: NA
  • Pymodbus: 1.4.0
  • Modbus Hardware (if used): NA

Pymodbus Specific

  • Server: tcp/rtu/ascii -async

Description

reactor.run() is invoked as part of StartTcpServer, StartUdpServer, StartSerialServer when running async servers. An option to be provided to defer reactor.run() call so that it could be called at some other place .

Reported/Suggested by @memetb on gitter
@dhoomakethu dhoomakethu added this to the 1.5.0 milestone Mar 29, 2018
dhoomakethu added a commit that referenced this issue Apr 9, 2018
@dhoomakethu
1. #284 Async servers - Option to start reactor outside Start<server>…
900db55 
…Server function

2. #283 Fix BinaryPayloadDecoder/Builder issues when using with pymodbus server
3. #278 Fix issue with sync/async servers failing to handle requests with transaction id > 255
4. #221 Move timing and transcational logic to framers for sync clients
5. #221 More debug logs for sync clients
6. Misc updates with examples and minor enhancements
dhoomakethu added a commit that referenced this issue Apr 26, 2018
@dhoomakethu
Pymodbus 1.5.0 (#285)
9d2c864 
*  Modbus sync client timing enhancements #221
 Fix TCP server #256, #260

* Fix #221 timing enhancements, #188 workarounds

* 1. #284 Async servers - Option to start reactor outside Start<server>Server function
2. #283 Fix BinaryPayloadDecoder/Builder issues when using with pymodbus server
3. #278 Fix issue with sync/async servers failing to handle requests with transaction id > 255
4. #221 Move timing and transcational logic to framers for sync clients
5. #221 More debug logs for sync clients
6. Misc updates with examples and minor enhancements

* 1. #277 MEI message reception issue with UDP client
2. Fix unit tests
3. Update changelog

* Patch 1 (#292)

* Fix #289 and other misc enhancements

* Replace nosetest with pytest

* Update Changelog

* serial sync client wait till timeout/some data is available in read buffer + update changelog

* serial sync client read updates when timeout is None and Zero

* fix sync client unit test and example
@dhoomakethu
Copy link
Contributor Author

Fixed as part of v.1.5.0, refer releases or dev branch

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhoomakethu