Eliminate more implicit optional (#1871)

pymodbus-dev · Oct 30, 2023 · 8b63dd2 · 8b63dd2
1 parent 1c96d93
commit 8b63dd2
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/pymodbus/client/serial.py b/pymodbus/client/serial.py
@@ -167,7 +167,6 @@ def __init__(
         **kwargs: Any,
     ) -> None:
         """Initialize Modbus Serial Client."""
-        self.transport = None
         kwargs["use_sync"] = True
         super().__init__(
             framer,

diff --git a/pymodbus/client/tcp.py b/pymodbus/client/tcp.py
@@ -149,7 +149,6 @@ def __init__(
         if "CommType" not in kwargs:
             kwargs["CommType"] = CommType.TCP
         kwargs["use_sync"] = True
-        self.transport = None
         super().__init__(
             framer,
             host=host,
@@ -160,7 +159,7 @@ def __init__(
         self.socket = None
 
     @property
-    def connected(self):
+    def connected(self) -> bool:
         """Connect internal."""
         return self.socket is not None
 

diff --git a/pymodbus/client/tls.py b/pymodbus/client/tls.py
@@ -156,7 +156,6 @@ def __init__(
         **kwargs: Any,
     ):
         """Initialize Modbus TLS Client."""
-        self.transport = None
         super().__init__(
             host, CommType=CommType.TLS, port=port, framer=framer, **kwargs
         )
@@ -166,7 +165,7 @@ def __init__(
         self.params.server_hostname = server_hostname
 
     @property
-    def connected(self):
+    def connected(self) -> bool:
         """Connect internal."""
         return self.transport is not None
 

diff --git a/pymodbus/client/udp.py b/pymodbus/client/udp.py
@@ -151,7 +151,6 @@ def __init__(
     ) -> None:
         """Initialize Modbus UDP Client."""
         kwargs["use_sync"] = True
-        self.transport = None
         super().__init__(
             framer,
             port=port,
@@ -164,7 +163,7 @@ def __init__(
         self.socket = None
 
     @property
-    def connected(self):
+    def connected(self) -> bool:
         """Connect internal."""
         return self.socket is not None