Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: multi-point-plan #176

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jul 7, 2024

This PR goes farther to formalize the relationship between all of the values in a well_points_plan, namely, they are all RelativeMultiPointPlan where

RelativeMultiPointPlan = Union[
    GridRowsColumns, GridWidthHeight, RandomPoints, RelativePosition
]

and they all support

    def __iter__(self) -> Iterator[RelativePosition]: ...
    def num_positions(self) -> int: ...

it also adds fov_height and width to the RelativePosition

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.90%. Comparing base (7cc1c96) to head (8b16c1b).

Files Patch % Lines
src/useq/_plate.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   95.70%   95.90%   +0.20%     
==========================================
  Files          16       16              
  Lines        1070     1075       +5     
==========================================
+ Hits         1024     1031       +7     
+ Misses         46       44       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 5801ee6 into pymmcore-plus:main Jul 7, 2024
24 checks passed
@tlambert03 tlambert03 deleted the multi-point-plan branch July 7, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant