Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix: update time interval exceeded boolean #147

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Oct 3, 2023

currently, interval=0 will pretty much always give you time_interval_exceeded = True

I think that in the case of a time_plan with interval=0, the time_interval_exceeded boolean should change depending on the sequence axis_order.

if axis_order="tpc", time_interval_exceeded=True
if axis_order="ptc", time_interval_exceeded=False

because...

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (c024a68) to head (613b5d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   95.65%   95.69%   +0.04%     
==========================================
  Files          15       15              
  Lines        1058     1069      +11     
==========================================
+ Hits         1012     1023      +11     
  Misses         46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdrgsp fdrgsp changed the title Fix: update time interval exceeded boolean [WIP] Fix: update time interval exceeded boolean Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants