Ignore causalpy/tests/ when running doctest to save a little time
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jpreszler, this looks great. The tests and doctests work for me locally. @ricardoV94 do you think we can get away with merging this despite the failing remote test, which I believe is being caused by the issue (#279) we discussed the other day? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 20 20
Lines 1305 1305
=======================================
Hits 990 990
Misses 315 315 ☔ View full report in Codecov by Sentry. |
|
Remote tests seem to pass now that pymc-devs/pytensor#550 is addressed in pytensor 2.18.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore
causalpy/tests/when running doctest to save a little time. Resolves issue #278.This cuts out the tests from being run twice, and doesn't doctest the docstrings in the tests - but none of them have examples so the doctests weren't doing much.
Locally, this went from 4m 50s to 3m 20s, so ~40% reduction in time.