Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace makefile commands with ruff #274

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

jsakv
Copy link
Contributor

@jsakv jsakv commented Nov 23, 2023

This PR replaces makefile commands with the ruff linter and formatted. The PR resolves #271
Changes:

  • Add isort rules to ruff config in the poetry.toml file
  • Replace existing noqa in the codebase with ruff noqa syntax
  • Replace the makefile commands with

Unfortunately, nbqa is only compatible with ruff check/ruff command not the ruff format so I kept it as is!

@jsakv jsakv changed the title #271 Replace makefile commands with ruff Replace makefile commands with ruff Nov 23, 2023
@jsakv jsakv marked this pull request as ready for review November 23, 2023 20:00
@jsakv jsakv marked this pull request as draft November 23, 2023 20:02
@jsakv jsakv marked this pull request as ready for review November 23, 2023 20:08
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2169bf0) 75.91% compared to head (395987c) 75.91%.

❗ Current head 395987c differs from pull request most recent head 4337625. Consider uploading reports for the commit 4337625 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files          20       20           
  Lines        1308     1308           
=======================================
  Hits          993      993           
  Misses        315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twiecki
Copy link
Contributor

twiecki commented Nov 23, 2023

@jsakv Thanks, see failing tests.

@jsakv
Copy link
Contributor Author

jsakv commented Nov 24, 2023

@twiecki, I fixed the linting it should be working now!

@drbenvincent drbenvincent added devops DevOps related no releasenotes Skipped in automatic release note generation labels Nov 24, 2023
@drbenvincent drbenvincent merged commit 83cb28c into pymc-labs:main Nov 24, 2023
9 checks passed
@drbenvincent
Copy link
Collaborator

Thanks for the contribution @jsakv 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps related no releasenotes Skipped in automatic release note generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check Makefile now that we use ruff
3 participants