-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User specified number of significant figures for numbers in plots #272
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
LGTM but there is a doc-test failing ¯\(ツ)/¯ |
Remote failing tests should hopefully be fixed whenever pymc-devs/pytensor#550 is fixed and make its way into a new pytensor release. Or when #279 is resolved. So don't sink any effort into trying to fix failing remote tests right now. You can of course ensure that all local tests pass - they are not affected by the issue. Not on my machine anyway. |
Well this is frustrating. Remote tests still not passing. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 75.86% 76.27% +0.41%
==========================================
Files 20 20
Lines 1305 1332 +27
==========================================
+ Hits 990 1016 +26
- Misses 315 316 +1 ☔ View full report in Codecov by Sentry. |
Closes #266.
The core functions (
round_num
and_format_sig_figs
) are taken from the Arviz repo.Tests are included.
I've re-run selected notebooks