Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User specified number of significant figures for numbers in plots #272

Merged
merged 16 commits into from
Dec 22, 2023

Conversation

drbenvincent
Copy link
Collaborator

Closes #266.

The core functions (round_num and _format_sig_figs) are taken from the Arviz repo.

Tests are included.

I've re-run selected notebooks

@drbenvincent drbenvincent added the enhancement New feature or request label Nov 16, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz
Copy link
Collaborator

LGTM but there is a doc-test failing ¯\(ツ)

@drbenvincent
Copy link
Collaborator Author

Remote failing tests should hopefully be fixed whenever pymc-devs/pytensor#550 is fixed and make its way into a new pytensor release. Or when #279 is resolved. So don't sink any effort into trying to fix failing remote tests right now. You can of course ensure that all local tests pass - they are not affected by the issue. Not on my machine anyway.

@drbenvincent
Copy link
Collaborator Author

Well this is frustrating. Remote tests still not passing.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (fc28a3b) 75.86% compared to head (198bde6) 76.27%.

Files Patch % Lines
causalpy/pymc_experiments.py 63.15% 7 Missing ⚠️
causalpy/skl_experiments.py 55.55% 4 Missing ⚠️
causalpy/utils.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   75.86%   76.27%   +0.41%     
==========================================
  Files          20       20              
  Lines        1305     1332      +27     
==========================================
+ Hits          990     1016      +26     
- Misses        315      316       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent drbenvincent merged commit 70de921 into main Dec 22, 2023
10 checks passed
@drbenvincent drbenvincent deleted the round_to branch December 22, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a round_to kwarg in all the plot methods
2 participants