Make blockwise perform method node dependent #1048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug surfaced in #1045. We were creating a single perform method per Blockwise Op, based on the node of which the Op was called the first time, even if the same Op was used for multiple nodes. This leads to incorrect results when the perform method depends on node info. This is valid behavior, so much that we pass
node
along to the perform method!📚 Documentation preview 📚: https://pytensor--1048.org.readthedocs.build/en/1048/