Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blockwise perform method node dependent #1048

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 23, 2024

Bug surfaced in #1045. We were creating a single perform method per Blockwise Op, based on the node of which the Op was called the first time, even if the same Op was used for multiple nodes. This leads to incorrect results when the perform method depends on node info. This is valid behavior, so much that we pass node along to the perform method!


📚 Documentation preview 📚: https://pytensor--1048.org.readthedocs.build/en/1048/

@ricardoV94 ricardoV94 added the bug Something isn't working label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (a377c22) to head (a12027f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/tensor/blockwise.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files         182      182           
  Lines       47879    47872    -7     
  Branches     8617     8617           
=======================================
- Hits        39214    39210    -4     
+ Misses       6492     6489    -3     
  Partials     2173     2173           
Files with missing lines Coverage Δ
pytensor/tensor/blockwise.py 82.10% <93.75%> (+0.88%) ⬆️

@ricardoV94 ricardoV94 merged commit dae731d into pymc-devs:main Oct 24, 2024
60 of 61 checks passed
@ricardoV94 ricardoV94 deleted the blockwise-bug branch October 24, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants