-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pygrep-hooks #7507
Merged
Merged
Enable pygrep-hooks #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Armavica
added
pre-commit
no releasenotes
Skipped in automatic release notes generation
labels
Sep 17, 2024
Armavica
force-pushed
the
pygrep-hooks
branch
from
September 17, 2024 15:56
5135a83
to
0be7ee5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7507 +/- ##
==========================================
+ Coverage 89.98% 92.69% +2.70%
==========================================
Files 104 104
Lines 17412 17408 -4
==========================================
+ Hits 15669 16137 +468
+ Misses 1743 1271 -472
|
ricardoV94
approved these changes
Oct 7, 2024
The failing tests don't seem a fluke. But not related to this PR either? |
No, they are failing on main too. |
Opened PR to fix it: #7529 |
twiecki
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds grep-based hooks that notably check for the use of double backticks for code in rst files, and that all noqa and type ignore statements are qualified.
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7507.org.readthedocs.build/en/7507/