Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed PytTensor import alias to pt in PyMC overview #7452

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Krupakar-Reddy-S
Copy link
Contributor

@Krupakar-Reddy-S Krupakar-Reddy-S commented Aug 9, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7452.org.readthedocs.build/en/7452/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Krupakar-Reddy-S
Copy link
Contributor Author

@twiecki I have made the changes in one commit, but still the diff is too large :(

@twiecki
Copy link
Member

twiecki commented Aug 9, 2024

@twiecki I have made the changes in one commit, but still the diff is too large :(

Yeah I think you need to start fresh. make a new branch from main, make that one change, and submit a new PR and abandon this branch.

@Krupakar-Reddy-S
Copy link
Contributor Author

Krupakar-Reddy-S commented Aug 9, 2024

I have done that, I deleted the branch made a new one from main but with the same name and then made that one commit, still shows large diff.

@twiecki
Copy link
Member

twiecki commented Aug 9, 2024

OK it's probably fine.

@twiecki twiecki merged commit f3cff73 into pymc-devs:main Aug 9, 2024
11 checks passed
Copy link

welcome bot commented Aug 9, 2024

Congratulations Banner]
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@twiecki
Copy link
Member

twiecki commented Aug 9, 2024

Thanks!

@ricardoV94 ricardoV94 changed the title Changed PytTensor import alias to pt Changed PytTensor import alias to pt in PyMC overview Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include README example in docs homepage
3 participants