-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mypy and versioneer settings to pyproject.toml #7382
Conversation
I took a very quick look. Very exciting, but there's a problem: $ python -m build .
...
Successfully built pymc-0.0.0.tar.gz and pymc-0.0.0-py3-none-any.whl It's picking up the version as 0.0.0. In contrast, on Successfully built pymc-5.15.1+52.gc2c46a764.tar.gz and pymc-5.15.1+52.gc2c46a764-py3-none-any.whl |
@maresb You are right, it looks like |
e10e16c
to
1fd6a86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I carefully compared the build artifacts before and after, and this looks good to go!
It's great to get rid of |
And use the non-vendor mode
Description
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7382.org.readthedocs.build/en/7382/