Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSGP misc fixes #7342

Merged
merged 7 commits into from
Jun 10, 2024
Merged

HSGP misc fixes #7342

merged 7 commits into from
Jun 10, 2024

Commits on Jun 1, 2024

  1. fix docstrings, fix centering calculations

    @bwengals
    bwengals committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    639e3b2 View commit details
    Browse the repository at this point in the history

  2. Change Xs to X, because the s indicated scaled, which we dont have to… 

    … do anymore
    @bwengals
    bwengals committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2b6ab5a View commit details
    Browse the repository at this point in the history

  3. fix test fails

    @bwengals
    bwengals committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    54bc64e View commit details
    Browse the repository at this point in the history

  4. remove c, HSGPParams tuple, fix docstring

    @bwengals
    bwengals committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4d96c28 View commit details
    Browse the repository at this point in the history

  5. add a bit more detail to docstring of set_boundary

    @bwengals
    bwengals committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    7640a18 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Compute S with more generic formula for radius

    @AlexAndorra
    AlexAndorra committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0ad3f9c View commit details
    Browse the repository at this point in the history

  2. Compute S with more generic formula for radius

    @AlexAndorra
    AlexAndorra committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5f760b9 View commit details
    Browse the repository at this point in the history