Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mutable shape in partially imputed variables #7314

Merged
merged 1 commit into from
May 14, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 14, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7314.org.readthedocs.build/en/7314/

@ricardoV94 ricardoV94 added the bug label May 14, 2024
@ricardoV94 ricardoV94 changed the title Allow mutable shape in PartialObservedRVs Allow mutable shape in imputade RVs May 14, 2024
@ricardoV94 ricardoV94 changed the title Allow mutable shape in imputade RVs Allow mutable shape in imputed variables May 14, 2024
@ricardoV94 ricardoV94 changed the title Allow mutable shape in imputed variables Allow mutable shape in partically imputed variables May 14, 2024
@ricardoV94 ricardoV94 changed the title Allow mutable shape in partically imputed variables Allow mutable shape in partially imputed variables May 14, 2024
Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight-forward enough. Seems like the JAX CI failures are unrelated, but I was wondering if it could interact with freeze_rvs_and_dims somehow. Maybe test?

@ricardoV94
Copy link
Member Author

Looks straight-forward enough. Seems like the JAX CI failures are unrelated, but I was wondering if it could interact with freeze_rvs_and_dims somehow. Maybe test?

Seems to be a change in JAX API of clip, not related to this PR

@jessegrabowski
Copy link
Member

Yeah I saw. It just got my noggin' joggin' about the other thing.

@ricardoV94
Copy link
Member Author

Yeah I saw. It just got my noggin' joggin' about the other thing.

We have a test for jax samplers with imputed variables. The question here I guess is freeze_rv_and_dims + direct JAX backend on model with imputed variables. I'll open an issue to add such a test

@ricardoV94 ricardoV94 merged commit 43b40de into pymc-devs:main May 14, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: NotConstantValueError when using coordinates observed data with missing values with pymc==5.14.0
2 participants