-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time remaining column to progress bars #7273
Conversation
While we're here can we also try to fix #7264 ? This issue suggests there should be |
Will try and fix #7278 here as well. |
Branch seems to have some conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. After my comment is addressed should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add time remaining column to progress bars * Consistent order remaining/elapsed * Disable sample_posterior_predictive taskbar when progressbar=False * Formatting * More formatting * More formatting (why doesnt pre-commit fix this?) * Disable progress bar when progress=False * Set refresh flag in progress bar updates * Typo
Description
Adds
TimeRemainingColumn
to progress bar where appropriate, also properly hides progressbar duringsample_posterior_predictive
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7273.org.readthedocs.build/en/7273/