Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable some compiler errors #7270

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Apr 21, 2024

Ideally we fix issues instead of suppressing them

Description

I'm hoping that pymc-devs/pytensor#725 will make this flag unnecessary. Looking forward to seeing what happens.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7270.org.readthedocs.build/en/7270/

Ideally we fix issues instead of suppressing them
@maresb
Copy link
Contributor Author

maresb commented Apr 22, 2024

@ricardoV94, it seems to me like we're missing these upstream macos failures since the PyTensor test suite doesn't run on macos. Any particular reason it's absent? Seems like it would be prudent to add.

@ricardoV94
Copy link
Member

@ricardoV94, it seems to me like we're missing these upstream macos failures since the PyTensor test suite doesn't run on macos. Any particular reason it's absent? Seems like it would be prudent to add.

We have refrained from duplicating the whole test suite across different OSes because it's pretty wasteful. But we can add other OS jobs with targeted tests. The hard part is just picking what to select

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants