Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example on expanded sample_posterior_predictive #7222

Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 27, 2024

Description

Sample posterior_predictive relies on other groups to infer volatility, so it's important to keep the whole InferenceData.

Also there's a shape error if sample_dims is not specified

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7222.org.readthedocs.build/en/7222/

Sample posterior_predictive relies on other groups to infer volatility, so it's important to keep the whole InferenceData.

Also there's a shape error if `sample_dims` is not specified
@ricardoV94 ricardoV94 merged commit 120fc4e into pymc-devs:main Mar 27, 2024
22 checks passed
@ricardoV94 ricardoV94 deleted the better_sample_posterior_pred_example branch March 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants