Refactor get_tau_sigma and support lists of variables
#7185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ricardoV94 other branch got mucked up during upstream rebase, so I closed that PR in favor of this one. It's ready for review when the checks are complete. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7185 +/- ##
==========================================
+ Coverage 92.24% 92.26% +0.02%
==========================================
Files 100 100
Lines 16888 16880 -8
==========================================
- Hits 15578 15574 -4
+ Misses 1310 1306 -4
|
|
I had to revert the behavior for negative |
|
@ricardoV94 Ready to merge |
ricardoV94
approved these changes
Mar 4, 2024
|
Thanks @tvwenger |
mkusnetsov
pushed a commit
to mkusnetsov/pymc
that referenced
this pull request
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR refactors the
get_tau_sigmalogic in order to support lists ofVariables and fixes #6987.N.B. The original code had a positivity check for non-
Variablearguments, but not forVariablearguments. Since this PR casts the arguments toVariable, I've removed the positivity check for non-Variablearguments.Resubmission of #6988
Checklist
Major / Breaking Changes
get_tau_sigmanow always returns aVariable, even when scalars are passedNew features
Bugfixes
get_tau_sigmadoes not support list of variables #6987Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--7185.org.readthedocs.build/en/7185/