Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in warn_treedepth when using multiple NUTS samplers #7182

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 1, 2024

Description

Fix issue reported in https://discourse.pymc.io/t/valueerror-the-truth-value-of-an-array-with-more-than-one-element-is-ambiguous-given-at-the-end-of-sampling/13875/3

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7182.org.readthedocs.build/en/7182/

@ricardoV94 ricardoV94 changed the title Fix error in warn_treedepth when using multiple NUTS sampler Fix error in warn_treedepth when using multiple NUTS samplers Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (6c6fd13) to head (6a12657).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7182   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         100      100           
  Lines       16887    16887           
=======================================
  Hits        15577    15577           
  Misses       1310     1310           
Files Coverage Δ
pymc/stats/convergence.py 97.43% <100.00%> (ø)
pymc/step_methods/hmc/nuts.py 97.27% <ø> (ø)

@ricardoV94 ricardoV94 merged commit 9bf2190 into pymc-devs:main Mar 1, 2024
24 checks passed
@ricardoV94
Copy link
Member Author

Thanks for the review @junpenglao! However, I'm slightly disappointed you didn't say "LGTM"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants