-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in dataset_to_point_list
when chain, draw are not the leading dims
#7180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7180 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 100 100
Lines 16887 16888 +1
=======================================
+ Hits 15577 15578 +1
Misses 1310 1310
|
mypy is unhappy |
OriolAbril
commented
Mar 1, 2024
OriolAbril
commented
Mar 1, 2024
I could only find 9ne failed test which seems unrelated (checking from my phone) |
Rerunning |
ricardoV94
changed the title
fix dataset_to_point_list
Fix error in dataset_to_point_list with unconventional position of sample dims
Mar 1, 2024
ricardoV94
changed the title
Fix error in dataset_to_point_list with unconventional position of sample dims
Fix error in Mar 1, 2024
dataset_to_point_list
when chain, draw are not the leading dims
ricardoV94
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the dict comprehension in two to keep transposing and reshaping coherent.
Otherwise, the sizes used in the reshaping are taken from the object before transposing
and the function doesn't work whenever the transposing is actually needed.
Related Issue
dataset_to_point_list
fails when chain, draw are not the leading dims #7178Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7180.org.readthedocs.build/en/7180/