Avoid inplace mutation in replace_rvs_by_values
#7055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
replace_rvs_by_values
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7055 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 101 101
Lines 16887 16893 +6
=======================================
+ Hits 15569 15575 +6
Misses 1318 1318
|
ricardoV94
force-pushed
the
avoid_inplace_replacement
branch
2 times, most recently
from
61fb352
to
ffbe943
Compare
|
Only tests failing are due to #7057 so this is ready for review |
twiecki
approved these changes
Dec 9, 2023
This would happen when transforms reference other variables
ricardoV94
force-pushed
the
avoid_inplace_replacement
branch
from
ffbe943
to
5d049dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7054
📚 Documentation preview 📚: https://pymc--7055.org.readthedocs.build/en/7055/