Remove several deprecated model properties and deprecate new ones #7033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
requested review from
twiecki,
lucianopaz,
michaelosthege and
ferrine
ricardoV94
changed the title
ricardoV94
changed the title
ricardoV94
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7033 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 101 101
Lines 16839 16827 -12
=======================================
- Hits 15520 15509 -11
+ Misses 1319 1318 -1
|
twiecki
reviewed
Nov 24, 2023
| @@ -559,6 +565,7 @@ def __init__( | |||
|
|
|||
| @property | |||
| def model(self): | |||
| warnings.warn("Model.model property is deprecated. Just use Model.", FutureWarning) | |||
twiecki
approved these changes
Nov 24, 2023
michaelosthege
approved these changes
Nov 24, 2023
ferrine
reviewed
Nov 24, 2023
| @@ -646,7 +653,7 @@ def compile_dlogp( | |||
| jacobian: | |||
| Whether to include jacobian terms in logprob graph. Defaults to True. | |||
| """ | |||
| return self.model.compile_fn(self.dlogp(vars=vars, jacobian=jacobian)) | |||
| return self.compile_fn(self.dlogp(vars=vars, jacobian=jacobian)) | |||
There was a problem hiding this comment.
Should not it be root model instead?
There was a problem hiding this comment.
This is the previous behavior. I don't know what should be happening with compiled function of nested models.
I think nested models are a mistake. The functionality we want to provide with them (plating) is much more narrow than what nested models do. We should probably use something like OpFromGraph for nested models, but that's another story.
ricardoV94
force-pushed
the
deprecate_useless_property
branch
from
4093531
to
e76ccb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes less is more...
The
self.modelseems to have been introduced with ancient GLM / ModelBuilder ideas: #1525@lucianopaz and I were surprised when we found it today. We thought we were getting a wrong object that wrapped model, but no, model does in fact have the most useless property ever :)
The deprecation of
pytensor_configwas discussed in #5915 and I think it's as good time as any to deprecate it.@ferrine was the proponent of this functionality. This only seems relevant if you want different modes for different models, but I say power-users can just use
pytensor.config.change_flagsmanually or build a helper that achieves the same functionality. The goal here is less magic. Note that this wouldn't work for nested models nor after cloning from fgraph asdoandobservedo.Removed a bunch of methods that were deprecated sometime ago
📚 Documentation preview 📚: https://pymc--7033.org.readthedocs.build/en/7033/