Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs formatting in shape_utils #7025

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

kataev
Copy link
Contributor

@kataev kataev commented Nov 22, 2023

Fix docs markup for this page and this

What is this PR about?
...

Checklist

Documentation

  • Small docs markup fixes

Copy link

welcome bot commented Nov 22, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@ricardoV94 ricardoV94 changed the title Small docs update shape_utils.py Fix docs formatting of shape_utils.py Nov 23, 2023
@ricardoV94 ricardoV94 changed the title Fix docs formatting of shape_utils.py Fix docs formatting f shape_utils.py Nov 23, 2023
@ricardoV94 ricardoV94 changed the title Fix docs formatting f shape_utils.py Fix docs formatting in shape_utils Nov 23, 2023
@ricardoV94
Copy link
Member

@OriolAbril Any idea why RTD is failing?

@OriolAbril
Copy link
Member

OriolAbril commented Nov 23, 2023

we have to merge #7018 and rebase (one of the dependencies took a bit longer to get on conda forge but now everything should work)

EDIT: I have already merged it

pymc/distributions/shape_utils.py Outdated Show resolved Hide resolved
pymc/distributions/shape_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #7025 (5cc43a5) into main (373274a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7025   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         101      101           
  Lines       16849    16849           
=======================================
  Hits        15530    15530           
  Misses       1319     1319           
Files Coverage Δ
pymc/distributions/shape_utils.py 94.94% <ø> (ø)

@OriolAbril OriolAbril merged commit ec70d86 into pymc-devs:main Nov 23, 2023
22 checks passed
Copy link

welcome bot commented Nov 23, 2023

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

LukeLB pushed a commit to LukeLB/pymc that referenced this pull request Nov 29, 2023
Update CODE_OF_CONDUCT.md

Changed contact email

ChiSquared now returns a Gamma random variable (pymc-devs#7007)

Update devcontainer (pymc-devs#7017)

* Update dev container on release and schedule

* Use latest version of upstream dev container image

* Remove pre-commit cache hack

* Add Jupyter extension to container

Rename RVTransform to Transform

Remove duplicate ChainTransform

Move ZeroSumTransform methods inside respective class

Remove deprecated function rvs_to_value_vars

Merge functionality of pytensorf and logprob/utils

Also fixes circular imports

Deprecate unused function walk_model

update theme (pymc-devs#7018)

* update theme version

* update conf.py

Fix docs formatting in `shape_utils` (pymc-devs#7025)

* Small docs update shape_utils.py

Fix docs markup

* Update to_tuple docs shape_utils.py

* Types

---------

Co-authored-by: Denis Kataev <[email protected]>

Use PyTensor StudentT RV

Update GOVERNANCE.md (pymc-devs#7031)

* Update GOVERNANCE.md

* Update GOVERNANCE.md

Co-authored-by: Purna Chandra Mansingh <[email protected]>

---------

Co-authored-by: Purna Chandra Mansingh <[email protected]>

Remove deprecated model methods

Deprecate Model.model property

Deprecate pytensor_config

Bump Pytensor dependency to >=2.18.1,<2.19

Better float32 sampling support for TruncatedNormal (pymc-devs#7026)

* manually inv transform; force rng same type

* always upcast f64 and downcast to dtype of param

* add comment

* use class attr dtype

* need else stmt for dtype

* actually no need to downcast in this method

* rm unused import

Another small fixes in docs and imports (pymc-devs#7030)

* Remove old import from autosummary doc pages

* Fix small error

* Correct place for model_to_networkx & model_to_graphviz

* Correct currentmodule source for pytensorf.rst

* Update docs/source/api/model/core.rst

Co-authored-by: Thomas Wiecki <[email protected]>

* Fix sampling & jax docs imports

---------

Co-authored-by: Denis Kataev <[email protected]>
Co-authored-by: Thomas Wiecki <[email protected]>

Update installation instructions to remove incompatibility of JAX on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants