Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in notebook about Distribution Dimensionality #7005

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

nicrie
Copy link
Contributor

@nicrie nicrie commented Nov 10, 2023

What is this PR about?
This is a simple typo correction in the documentation. In the notebook about Distribution Dimensionality there seems to be a simple mix-up in the dimension order.

If you needed the Normal variables to have shape=(4, 3), you can transpose it after defining it.

To my understanding, it should be "shape=(3, 4)", as underlined by the fact the the following cell produces an output of shape (3, 4).

Checklist

Major / Breaking Changes

None

New features

None

Bugfixes

None

Documentation

Maintenance

None


📚 Documentation preview 📚: https://pymc--7005.org.readthedocs.build/en/7005/

The order of shape got probably mixed-up here.
Copy link

welcome bot commented Nov 10, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch

@ricardoV94 ricardoV94 merged commit d7415de into pymc-devs:main Nov 10, 2023
1 of 2 checks passed
Copy link

welcome bot commented Nov 10, 2023

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants