-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge redundant code across logprob
, pytensorf
and distributions/transform
#6976
Conversation
965705f
to
74e9d5e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6976 +/- ##
==========================================
- Coverage 87.66% 80.12% -7.54%
==========================================
Files 101 101
Lines 16964 16858 -106
==========================================
- Hits 14871 13507 -1364
- Misses 2093 3351 +1258
|
d87a82a
to
468e043
Compare
Converted to draft as there are two bugfix PRs that involve transforms and will certainly conflict with this one |
Also fixes circular imports
468e043
to
322b3d3
Compare
Ready for review again. I am still divided about what to do with the custom Transforms implemented in I am more inclined for the latter, but for now I just removed duplicated functionality (Chain vs ChainedTransform) and left everything in the same place. |
Helps with #6908
Closes #6859
Also gets rid of some annoying circular imports
📚 Documentation preview 📚: https://pymc--6976.org.readthedocs.build/en/6976/