Include more PyTensor functions in math module #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like |
|
Might be called full_like (in which case we want full instead of fill as well) |
ricardoV94
changed the title
ricardoV94
changed the title
jaharvey8
force-pushed
the
fix-issue-6948
branch
from
260e8fa
to
f69846e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6956 +/- ##
==========================================
+ Coverage 89.01% 92.14% +3.12%
==========================================
Files 100 100
Lines 16859 16859
==========================================
+ Hits 15007 15534 +527
+ Misses 1852 1325 -527
|
ricardoV94
approved these changes
Oct 20, 2023
|
LGTM, any other thing people would like to add? CC @cluhmann |
twiecki
approved these changes
Oct 20, 2023
|
Nice! This looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added zeros, ones, fill, fill_like, broadcast_to, mean, matmul to math.py issue #6948
📚 Documentation preview 📚: https://pymc--6956.org.readthedocs.build/en/6956/