-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gamma Distribution to support new pytensor GammaRV reparameterization #6934
Conversation
I'm updating this PR following the proposed changes to the
The logic was right, but the variable names for |
We can add a regression test for the TruncatedGamma bug you uncovered, while we wait for the PyTensor PR to be merged and a new release |
Actually it seems we need the Gamma fix first :) I'm going to push stuff here |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6934 +/- ##
==========================================
- Coverage 92.15% 88.53% -3.63%
==========================================
Files 100 100
Lines 16853 16854 +1
==========================================
- Hits 15531 14921 -610
- Misses 1322 1933 +611
|
What is this PR about?
This PR implements a nativeThe updatedGammaRV
inpymc
, which uses the same parameterization as theGamma
distribution (i.e.,beta
instead ofinv_beta
).GammaRV
inpytensor
is included in this dependent PR. This allows theTruncated
wrapper to handle this distribution properly and fixes #6931Also fixes #6938
Checklist
Major / Breaking Changes
Removes dependency onpytensor
'sGammaRV
.New features
None
Bugfixes
Fixes parameter mismatch between
pytensor
'sGammaRV
andpymc
'sGamma
distribution.Documentation
Included
Maintenance
N/A
📚 Documentation preview 📚: https://pymc--6934.org.readthedocs.build/en/6934/