Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update case study to match blog post #6930

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

thompsonjjet23
Copy link
Contributor

@thompsonjjet23 thompsonjjet23 commented Sep 25, 2023

Update case study example to match blog post


📚 Documentation preview 📚: https://pymc--6930.org.readthedocs.build/en/6930/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@twiecki
Copy link
Member

twiecki commented Sep 25, 2023

Don't you have to re-execute?

@thompsonjjet23
Copy link
Contributor Author

Don't you have to re-execute?

@twiecki I was having trouble running this notebook when I tried to re-execute --

In cell 13:

test_scores = pd.read_csv(pm.get_data("test_scores.csv"), index_col=0)
test_scores.head()

I get this error when trying to read the test scores data:

URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain (_ssl.c:997)>

I tried googling around a bit but I'm not sure how to fix it , have you seen that error before?

@twiecki
Copy link
Member

twiecki commented Sep 26, 2023

It sounds like the link has gotten stale. Can you download from that link manually? Otherwise, can you find a new one and fix that?

@thompsonjjet23
Copy link
Contributor Author

thompsonjjet23 commented Sep 27, 2023

It sounds like the link has gotten stale. Can you download from that link manually? Otherwise, can you find a new one and fix that?

Ah yes -- if I go here I can find the data: https://raw.githubusercontent.com/pymc-devs/pymc-examples/main/examples/data/test_scores.csv

i was able to download it manually and re-execute the notebook -- I think it looks ok now?

@thompsonjjet23
Copy link
Contributor Author

@twiecki is there any chance that the mypy failure here could be related to #6926 ? it's odd that it's complaining about data.py since I didn't modify that file in this PR?

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 27, 2023

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2023-09-27T10:29:48Z
----------------------------------------------------------------

This plot is missing.


@thompsonjjet23
Copy link
Contributor Author

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2023-09-27T10:29:48Z ----------------------------------------------------------------

This plot is missing.

fixed!

@twiecki twiecki merged commit 5ed39c3 into pymc-devs:main Sep 29, 2023
9 of 10 checks passed
@twiecki
Copy link
Member

twiecki commented Sep 29, 2023

Thanks!

@ricardoV94 ricardoV94 added the docs label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants