Default to Scan in postprocessing of jax samplers #6922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6922 +/- ##
==========================================
- Coverage 92.16% 92.13% -0.03%
==========================================
Files 100 100
Lines 16839 16853 +14
==========================================
+ Hits 15519 15528 +9
- Misses 1320 1325 +5
|
|
@junpenglao can you please have a look? |
junpenglao
reviewed
Sep 22, 2023
ferrine
force-pushed
the
fix-jax-sampling
branch
from
d30a316
to
07d4734
Compare
ferrine
force-pushed
the
fix-jax-sampling
branch
from
ad3f877
to
d3a3fb0
Compare
|
The failed tests seem to be unrelated, anything else I need to take care of? @junpenglao @ricardoV94 |
ricardoV94
reviewed
Sep 23, 2023
ferrine
force-pushed
the
fix-jax-sampling
branch
from
f3b256b
to
ca1caf1
Compare
|
commited the suggestions by @ricardoV94 |
1 similar comment
|
commited the suggestions by @ricardoV94 |
junpenglao
approved these changes
Sep 24, 2023
ricardoV94
approved these changes
Sep 24, 2023
ferrine
commented
Sep 24, 2023
ricardoV94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Fixing sansible defaults in jax post processing and updating to blackjax 1.0.0 api
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6922.org.readthedocs.build/en/6922/