Add optional support for McBackend-based trace backends #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trace-refactoring #6501 +/- ##
======================================================
- Coverage 94.83% 39.12% -55.71%
======================================================
Files 148 150 +2
Lines 27820 27981 +161
======================================================
- Hits 26382 10948 -15434
- Misses 1438 17033 +15595
|
michaelosthege
force-pushed
the
optional-mcb
branch
4 times, most recently
from
f474303
to
9d088d4
Compare
The mcmc module relies on the `"tune"` stat to figure out the number of tune/draw iterations post sampling. These changes remove reliance on any weird squeeze-cat magic.
michaelosthege
force-pushed
the
optional-mcb
branch
from
b73a8ab
to
d4e8f6d
Compare
michaelosthege
force-pushed
the
optional-mcb
branch
from
d4e8f6d
to
19df620
Compare
michaelosthege
force-pushed
the
trace-refactoring
branch
from
27ea781
to
7f949ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements optional support for McBackend based trace backends.
This builds on top of the refactorings from #6475 that decoupled the
pm.samplingmodule fromBaseTrace.I split the addition of McBackend support into two commits, the first of which makes the necessary code changes without actually adding McBackend as a dependency for the test environments just to confirm that the optional importing works.
The
mcbackend.RunMetaobject that is created by themake_runmetafunction contains several important metadata about the current model variables. This includes information such as whether a variable is deterministic or not. Related issues:Checklist
New features
pm.sample(trace=...)now acceptsmcbackend.Backendinstances.Bugfixes
Statsbijection.rmapcan now take incomplete input dicts.Maintenance