Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Aesara version to 2.8.1 #6052

Closed
wants to merge 2 commits into from
Closed

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Aug 16, 2022

What is this PR about?
A new version of Aesara just landed.

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

@maresb maresb marked this pull request as ready for review August 16, 2022 20:35
@maresb
Copy link
Contributor Author

maresb commented Aug 16, 2022

This shouldn't be necessary to resolve conda-forge/pymc-feedstock#58 but it would still be nice to have if it doesn't cause delays.

@maresb
Copy link
Contributor Author

maresb commented Aug 16, 2022

Currently failing because the Aesara feedstock hasn't been updated yet.

@maresb
Copy link
Contributor Author

maresb commented Aug 16, 2022

@maresb
Copy link
Contributor Author

maresb commented Aug 16, 2022

This requires further investigation. In order to promptly address the setuptools issue, I would vote to include this in a subsequent release.

@maresb maresb marked this pull request as draft August 16, 2022 21:13
@maresb
Copy link
Contributor Author

maresb commented Aug 20, 2022

Blocked by aesara-devs/aesara#1129

@maresb maresb changed the title Bump Aesara version to 2.7.10 Bump Aesara version to 2.8.1 Aug 21, 2022
@maresb
Copy link
Contributor Author

maresb commented Aug 21, 2022

After doing s/2.7.10/2.8.1/ locally, pre-commit is failing, looks like there may be some incoming mypy types! 🤓

@maresb
Copy link
Contributor Author

maresb commented Aug 22, 2022

Now v2.8.2 has been released.

When I opened this, I didn't realize that the change might be substantial. (See aesara-devs/aesara#1054). I sadly don't have any time to work on this now, and since my original effort was a mere search-replace, I'm closing this out for now in hopes that someone else takes it up.

@maresb maresb closed this Aug 22, 2022
@maresb
Copy link
Contributor Author

maresb commented Aug 25, 2022

Completed in #6059

@maresb maresb deleted the bump-aesara branch August 25, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant