Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EllipticalSlice sampler #5756

Merged
merged 1 commit into from
May 9, 2022

Conversation

michaelosthege
Copy link
Member

Closes #5137

  • Removes the EllipticalSlice sampler which has not been migrated to v4 to begin with. (Nobody showed interest in it.)
  • Lots of deleted lines 🤗
  • ✔ Mentioned in the RELEASE-NOTES.

@michaelosthege michaelosthege added this to the v4.0.0 milestone May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #5756 (7421b6e) into main (49eecfb) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5756      +/-   ##
==========================================
+ Coverage   89.22%   89.27%   +0.04%     
==========================================
  Files          75       74       -1     
  Lines       13846    13803      -43     
==========================================
- Hits        12354    12322      -32     
+ Misses       1492     1481      -11     
Impacted Files Coverage Δ
pymc/step_methods/__init__.py 100.00% <ø> (ø)
pymc/sampling.py 88.16% <0.00%> (-0.35%) ⬇️

@ricardoV94 ricardoV94 merged commit ab593b1 into pymc-devs:main May 9, 2022
@michaelosthege michaelosthege deleted the remove-ellipticalslice branch May 9, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EllipticalSlice for V4
3 participants