Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #5689

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Misc changes #5689

merged 2 commits into from
Apr 5, 2022

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Apr 4, 2022

This PR is a minor spinoff of #4775

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #5689 (cb76083) into main (f1bd401) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5689      +/-   ##
==========================================
+ Coverage   88.82%   88.84%   +0.02%     
==========================================
  Files          75       75              
  Lines       13736    13737       +1     
==========================================
+ Hits        12201    12205       +4     
+ Misses       1535     1532       -3     
Impacted Files Coverage Δ
pymc/math.py 70.04% <ø> (ø)
pymc/distributions/discrete.py 99.73% <100.00%> (ø)
pymc/distributions/mixture.py 97.08% <0.00%> (+1.47%) ⬆️

pymc/math.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 force-pushed the add_log1pexp_numpy branch 2 times, most recently from f28ea64 to cb76083 Compare April 5, 2022 09:30
@ricardoV94
Copy link
Member Author

Realized there was no point in implementing the log1pexp_numpy since the np.where will evaluate all the branches, precluding any speed benefits

@ricardoV94 ricardoV94 requested a review from twiecki April 5, 2022 10:32
@ricardoV94 ricardoV94 changed the title Add log1pexp_numpy helper Misc changes Apr 5, 2022
@ricardoV94 ricardoV94 merged commit f9317f9 into pymc-devs:main Apr 5, 2022
@ricardoV94 ricardoV94 deleted the add_log1pexp_numpy branch August 31, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants